diff options
| author | YueHaibing <yuehaibing@huawei.com> | 2019-01-23 13:00:22 +0100 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2019-01-23 16:45:37 +0100 |
| commit | e902cdcb5112b89ee445588147964723fd69ffb4 (patch) | |
| tree | 91a285cafe9df4664602d2b17680297d839c4216 /drivers/spi/spi-topcliff-pch.c | |
| parent | spi: spi-mem: Fix a memory leak in spi_mem_dirmap_destroy() (diff) | |
| download | linux-e902cdcb5112b89ee445588147964723fd69ffb4.tar.xz linux-e902cdcb5112b89ee445588147964723fd69ffb4.zip | |
spi/topcliff_pch: Fix potential NULL dereference on allocation error
In pch_spi_handle_dma, it doesn't check for NULL returns of kcalloc
so it would result in an Oops.
Fixes: c37f3c2749b5 ("spi/topcliff_pch: DMA support")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi/spi-topcliff-pch.c')
| -rw-r--r-- | drivers/spi/spi-topcliff-pch.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c index 97d137591b18..e7e8ea1edcce 100644 --- a/drivers/spi/spi-topcliff-pch.c +++ b/drivers/spi/spi-topcliff-pch.c @@ -1008,6 +1008,9 @@ static void pch_spi_handle_dma(struct pch_spi_data *data, int *bpw) /* RX */ dma->sg_rx_p = kcalloc(num, sizeof(*dma->sg_rx_p), GFP_ATOMIC); + if (!dma->sg_rx_p) + return; + sg_init_table(dma->sg_rx_p, num); /* Initialize SG table */ /* offset, length setting */ sg = dma->sg_rx_p; @@ -1068,6 +1071,9 @@ static void pch_spi_handle_dma(struct pch_spi_data *data, int *bpw) } dma->sg_tx_p = kcalloc(num, sizeof(*dma->sg_tx_p), GFP_ATOMIC); + if (!dma->sg_tx_p) + return; + sg_init_table(dma->sg_tx_p, num); /* Initialize SG table */ /* offset, length setting */ sg = dma->sg_tx_p; |