diff options
| author | Wei Yongjun <weiyongjun1@huawei.com> | 2021-04-12 18:00:25 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2021-04-12 18:07:39 +0200 |
| commit | 6043357263fbe2df0bf0736d971ad5dce7d19dc1 (patch) | |
| tree | 112f59f10ccc1bdfa271d45a44725668b5a628b3 /drivers/spi/spi-zynqmp-gqspi.c | |
| parent | Merge series "spi: spi-zynqmp-gpspi: fix some issues" from quanyang.wang@wind... (diff) | |
| download | linux-6043357263fbe2df0bf0736d971ad5dce7d19dc1.tar.xz linux-6043357263fbe2df0bf0736d971ad5dce7d19dc1.zip | |
spi: spi-zynqmp-gqspi: Fix missing unlock on error in zynqmp_qspi_exec_op()
Add the missing unlock before return from function zynqmp_qspi_exec_op()
in the error handling case.
Fixes: a0f65be6e880 ("spi: spi-zynqmp-gqspi: add mutex locking for exec_op")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Link: https://lore.kernel.org/r/20210412160025.194171-1-weiyongjun1@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi/spi-zynqmp-gqspi.c')
| -rw-r--r-- | drivers/spi/spi-zynqmp-gqspi.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/spi/spi-zynqmp-gqspi.c b/drivers/spi/spi-zynqmp-gqspi.c index 036d8ae41c06..408e348382c5 100644 --- a/drivers/spi/spi-zynqmp-gqspi.c +++ b/drivers/spi/spi-zynqmp-gqspi.c @@ -965,8 +965,10 @@ static int zynqmp_qspi_exec_op(struct spi_mem *mem, if (op->cmd.opcode) { tmpbuf = kzalloc(op->cmd.nbytes, GFP_KERNEL | GFP_DMA); - if (!tmpbuf) + if (!tmpbuf) { + mutex_unlock(&xqspi->op_lock); return -ENOMEM; + } tmpbuf[0] = op->cmd.opcode; reinit_completion(&xqspi->data_completion); xqspi->txbuf = tmpbuf; |