diff options
| author | Barry Song <barry.song@analog.com> | 2010-04-06 05:36:24 +0200 |
|---|---|---|
| committer | Mike Frysinger <vapier@gentoo.org> | 2010-10-18 08:49:43 +0200 |
| commit | 4190f6a51f3f9c7c8298202d31b3ead9381c33f1 (patch) | |
| tree | b1afa6ba60935d2a8036714ea46d4acd8b36a877 /drivers/spi/spi_bfin5xx.c | |
| parent | spi/bfin_spi: cs should be always low when a new transfer begins (diff) | |
| download | linux-4190f6a51f3f9c7c8298202d31b3ead9381c33f1.tar.xz linux-4190f6a51f3f9c7c8298202d31b3ead9381c33f1.zip | |
spi/bfin_spi: warn when CS is driven by hardware (CPHA=0)
When the hardware is controlling the CS, there are some SPI options
we are unable to support. So issue a warning in the hopes that the
user will change to a SPI mode where we can support things sanely.
Signed-off-by: Barry Song <barry.song@analog.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Diffstat (limited to 'drivers/spi/spi_bfin5xx.c')
| -rw-r--r-- | drivers/spi/spi_bfin5xx.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/drivers/spi/spi_bfin5xx.c b/drivers/spi/spi_bfin5xx.c index 7882afcd580f..21de8605dbce 100644 --- a/drivers/spi/spi_bfin5xx.c +++ b/drivers/spi/spi_bfin5xx.c @@ -1040,9 +1040,14 @@ static int bfin_spi_setup(struct spi_device *spi) */ chip->baud = hz_to_spi_baud(spi->max_speed_hz); chip->chip_select_num = spi->chip_select; - if (chip->chip_select_num < MAX_CTRL_CS) + if (chip->chip_select_num < MAX_CTRL_CS) { + if (!(spi->mode & SPI_CPHA)) + dev_warn(&spi->dev, "Warning: SPI CPHA not set:" + " Slave Select not under software control!\n" + " See Documentation/blackfin/bfin-spi-notes.txt"); + chip->flag = (1 << spi->chip_select) << 8; - else + } else chip->cs_gpio = chip->chip_select_num - MAX_CTRL_CS; if (chip->enable_dma && chip->pio_interrupt) { |