diff options
| author | Haavard Skinnemoen <hskinnemoen@atmel.com> | 2008-02-06 10:38:13 +0100 |
|---|---|---|
| committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2008-02-06 19:41:10 +0100 |
| commit | 8bacb219018a52e6f02a3cff6a7badf102ddfc44 (patch) | |
| tree | 7e89a0346ce1694c32cf035c2badb2ff77db6a00 /drivers/spi/spi_s3c24xx.c | |
| parent | atmel_spi: chain DMA transfers (diff) | |
| download | linux-8bacb219018a52e6f02a3cff6a7badf102ddfc44.tar.xz linux-8bacb219018a52e6f02a3cff6a7badf102ddfc44.zip | |
atmel_spi: fix dmachain oops with DEBUG enabled
In atmel_spi_next_xfer, xfer can be NULL because the next transfer may
already have been submitted to the PDC (using DMA chaining). This can
cause an oops, since the debug message assumed it was never null. The
fix changes how those debug messages are issued, ensuring that one is
issued each time a transfer is started instead of once per call.
Also, properly indent the "can this transfer be chained" test so it's
not hidden as if it were non-conditional code.
Signed-off-by: Haavard Skinnemoen <hskinnemoen@atmel.com>
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/spi/spi_s3c24xx.c')
0 files changed, 0 insertions, 0 deletions