diff options
| author | Bartosz Golaszewski <bartosz.golaszewski@linaro.org> | 2023-01-06 11:07:19 +0100 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2023-01-11 15:15:10 +0100 |
| commit | 6b35b173dbc1711f8d272e3f322d2ad697015919 (patch) | |
| tree | 78ee7db1d6452e20a51cec6fc88605ffb2fc975b /drivers/spi/spidev.c | |
| parent | spi: spidev: fix a race condition when accessing spidev->spi (diff) | |
| download | linux-6b35b173dbc1711f8d272e3f322d2ad697015919.tar.xz linux-6b35b173dbc1711f8d272e3f322d2ad697015919.zip | |
spi: spidev: remove debug messages that access spidev->spi without locking
The two debug messages in spidev_open() dereference spidev->spi without
taking the lock and without checking if it's not null. This can lead to
a crash. Drop the messages as they're not needed - the user-space will
get informed about ENOMEM with the syscall return value.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Link: https://lore.kernel.org/r/20230106100719.196243-2-brgl@bgdev.pl
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi/spidev.c')
| -rw-r--r-- | drivers/spi/spidev.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c index 42aaaca67265..1935ca613447 100644 --- a/drivers/spi/spidev.c +++ b/drivers/spi/spidev.c @@ -603,7 +603,6 @@ static int spidev_open(struct inode *inode, struct file *filp) if (!spidev->tx_buffer) { spidev->tx_buffer = kmalloc(bufsiz, GFP_KERNEL); if (!spidev->tx_buffer) { - dev_dbg(&spidev->spi->dev, "open/ENOMEM\n"); status = -ENOMEM; goto err_find_dev; } @@ -612,7 +611,6 @@ static int spidev_open(struct inode *inode, struct file *filp) if (!spidev->rx_buffer) { spidev->rx_buffer = kmalloc(bufsiz, GFP_KERNEL); if (!spidev->rx_buffer) { - dev_dbg(&spidev->spi->dev, "open/ENOMEM\n"); status = -ENOMEM; goto err_alloc_rx_buf; } |