diff options
| author | Wan Jiabing <wanjiabing@vivo.com> | 2021-10-15 05:39:17 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2021-10-15 17:11:00 +0200 |
| commit | 2a4a4e8918f002c9da41d4ffb643ea78b1aa4a4f (patch) | |
| tree | 42ccf4a0459baf1088d0dbb86f145269328fbd2d /drivers/spi | |
| parent | spi: orion: Add of_node_put() before goto (diff) | |
| download | linux-2a4a4e8918f002c9da41d4ffb643ea78b1aa4a4f.tar.xz linux-2a4a4e8918f002c9da41d4ffb643ea78b1aa4a4f.zip | |
spi: cadence: Add of_node_put() before return
Fix following coccicheck warning:
./drivers/spi/spi-cadence-xspi.c:490:1-23: WARNING: Function
for_each_child_of_node should have of_node_put() before return
Early exits from for_each_child_of_node should decrement the
node reference counter.
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Link: https://lore.kernel.org/r/20211015033919.5915-1-wanjiabing@vivo.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi')
| -rw-r--r-- | drivers/spi/spi-cadence-xspi.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/spi/spi-cadence-xspi.c b/drivers/spi/spi-cadence-xspi.c index 6bd0e67fedf4..4bc1b93fc276 100644 --- a/drivers/spi/spi-cadence-xspi.c +++ b/drivers/spi/spi-cadence-xspi.c @@ -493,9 +493,11 @@ static int cdns_xspi_of_get_plat_data(struct platform_device *pdev) if (of_property_read_u32(node_child, "reg", &cs)) { dev_err(&pdev->dev, "Couldn't get memory chip select\n"); + of_node_put(node_child); return -ENXIO; } else if (cs >= CDNS_XSPI_MAX_BANKS) { dev_err(&pdev->dev, "reg (cs) parameter value too large\n"); + of_node_put(node_child); return -ENXIO; } } |