summaryrefslogtreecommitdiffstats
path: root/drivers/spi
diff options
context:
space:
mode:
authorXu Qiang <xuqiang36@huawei.com>2022-08-25 08:53:24 +0200
committerMark Brown <broonie@kernel.org>2022-09-05 14:09:51 +0200
commit494a22765ce479c9f8ad181c5d24cffda9f534bb (patch)
tree5a635dcfff71fe7981a5dd57d205c02c25e19abb /drivers/spi
parentspi: qup: add missing clk_disable_unprepare on error in spi_qup_resume() (diff)
downloadlinux-494a22765ce479c9f8ad181c5d24cffda9f534bb.tar.xz
linux-494a22765ce479c9f8ad181c5d24cffda9f534bb.zip
spi: qup: add missing clk_disable_unprepare on error in spi_qup_pm_resume_runtime()
Add the missing clk_disable_unprepare() before return from spi_qup_pm_resume_runtime() in the error handling case. Fixes: dae1a7700b34 (“spi: qup: Handle clocks in pm_runtime suspend and resume”) Signed-off-by: Xu Qiang <xuqiang36@huawei.com> Link: https://lore.kernel.org/r/20220825065324.68446-2-xuqiang36@huawei.com Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi')
-rw-r--r--drivers/spi/spi-qup.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c
index ae4e67f152ec..7d89510dc3f0 100644
--- a/drivers/spi/spi-qup.c
+++ b/drivers/spi/spi-qup.c
@@ -1198,8 +1198,10 @@ static int spi_qup_pm_resume_runtime(struct device *device)
return ret;
ret = clk_prepare_enable(controller->cclk);
- if (ret)
+ if (ret) {
+ clk_disable_unprepare(controller->iclk);
return ret;
+ }
/* Disable clocks auto gaiting */
config = readl_relaxed(controller->base + QUP_CONFIG);