diff options
| author | Clark Wang <xiaoning.wang@nxp.com> | 2020-11-24 09:52:47 +0100 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2020-11-24 15:14:02 +0100 |
| commit | 7cd71202961090d8f2d2b863ec66b25ae43e1d39 (patch) | |
| tree | 6c4aacf25eb4e9895c2e5a27cfe50b4570e7abd4 /drivers/spi | |
| parent | spi: spi-nxp-fspi: fix fspi panic by unexpected interrupts (diff) | |
| download | linux-7cd71202961090d8f2d2b863ec66b25ae43e1d39.tar.xz linux-7cd71202961090d8f2d2b863ec66b25ae43e1d39.zip | |
spi: imx: fix the unbalanced spi runtime pm management
If set active without increase the usage count of pm, the dont use
autosuspend function will call the suspend callback to close the two
clocks of spi because the usage count is reduced to -1.
This will cause the warning dump below when the defer-probe occurs.
[ 129.379701] ecspi2_root_clk already disabled
[ 129.384005] WARNING: CPU: 1 PID: 33 at drivers/clk/clk.c:952 clk_core_disable+0xa4/0xb0
So add the get noresume function before set active.
Fixes: 43b6bf406cd0 spi: imx: fix runtime pm support for !CONFIG_PM
Signed-off-by: Clark Wang <xiaoning.wang@nxp.com>
Link: https://lore.kernel.org/r/20201124085247.18025-1-xiaoning.wang@nxp.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi')
| -rw-r--r-- | drivers/spi/spi-imx.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c index 4b80e27ecdbf..0b597905ee72 100644 --- a/drivers/spi/spi-imx.c +++ b/drivers/spi/spi-imx.c @@ -1686,6 +1686,7 @@ static int spi_imx_probe(struct platform_device *pdev) pm_runtime_set_autosuspend_delay(spi_imx->dev, MXC_RPM_TIMEOUT); pm_runtime_use_autosuspend(spi_imx->dev); + pm_runtime_get_noresume(spi_imx->dev); pm_runtime_set_active(spi_imx->dev); pm_runtime_enable(spi_imx->dev); |