diff options
| author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2017-08-08 06:45:02 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2017-08-08 12:36:07 +0200 |
| commit | 9a6b94796ae6feaf275ec6200e9b2964db208182 (patch) | |
| tree | 15be0a96b480bf376add9e5138d176c454d55f5e /drivers/spi | |
| parent | Linux v4.13-rc1 (diff) | |
| download | linux-9a6b94796ae6feaf275ec6200e9b2964db208182.tar.xz linux-9a6b94796ae6feaf275ec6200e9b2964db208182.zip | |
spi: xlp: fix error return code in xlp_spi_probe()
platform_get_irq() returns an error code, but the spi-xlp driver ignores
it and always returns -EINVAL. This is not correct and, prevents
-EPROBE_DEFER from being propagated properly.
Notice that platform_get_irq() no longer returns 0 on error:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af
Print and propagate the return value of platform_get_irq on failure.
This issue was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi')
| -rw-r--r-- | drivers/spi/spi-xlp.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/spi/spi-xlp.c b/drivers/spi/spi-xlp.c index 80cb4d6af892..74a01b09a8a5 100644 --- a/drivers/spi/spi-xlp.c +++ b/drivers/spi/spi-xlp.c @@ -393,8 +393,8 @@ static int xlp_spi_probe(struct platform_device *pdev) irq = platform_get_irq(pdev, 0); if (irq < 0) { - dev_err(&pdev->dev, "no IRQ resource found\n"); - return -EINVAL; + dev_err(&pdev->dev, "no IRQ resource found: %d\n", irq); + return irq; } err = devm_request_irq(&pdev->dev, irq, xlp_spi_interrupt, 0, pdev->name, xspi); |