diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2012-05-08 12:28:59 +0200 |
|---|---|---|
| committer | Nicholas Bellinger <nab@linux-iscsi.org> | 2012-05-10 00:07:44 +0200 |
| commit | 2301917044b96fda41f794011368e623a9b7a435 (patch) | |
| tree | 74a928f86be838214f6351d2a58b8c63b0e83b11 /drivers/target | |
| parent | target: Enforce hw_max_sectors for SCF_SCSI_DATA_SG_IO_CDB (diff) | |
| download | linux-2301917044b96fda41f794011368e623a9b7a435.tar.xz linux-2301917044b96fda41f794011368e623a9b7a435.zip | |
target: lock => unlock typo in transport_lun_wait_for_tasks
target_stop_cmd() returns with the lock held and IRQs disabled. The
intent was to unlock here. This bug was originally added with:
commit cf572a9627c9ae86082216de109780c1d2e2ee28
Author: Christoph Hellwig <hch@infradead.org>
Date: Tue Apr 24 00:25:05 2012 -0400
target: move the state and execute lists to the command
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'drivers/target')
| -rw-r--r-- | drivers/target/target_core_transport.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c index a10d7847f037..85f14e0fe5d3 100644 --- a/drivers/target/target_core_transport.c +++ b/drivers/target/target_core_transport.c @@ -3768,7 +3768,7 @@ static int transport_lun_wait_for_tasks(struct se_cmd *cmd, struct se_lun *lun) (cmd->transport_state & CMD_T_SENT)) { if (!target_stop_cmd(cmd, &flags)) ret++; - spin_lock_irqsave(&cmd->t_state_lock, flags); + spin_unlock_irqrestore(&cmd->t_state_lock, flags); } else { spin_unlock_irqrestore(&cmd->t_state_lock, flags); |