diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2016-12-13 13:27:04 +0100 |
|---|---|---|
| committer | Bart Van Assche <bart.vanassche@sandisk.com> | 2016-12-16 11:15:11 +0100 |
| commit | a91918cd3ea11f91c68e08e1e8ce1b560447a80e (patch) | |
| tree | 82866d98bcc777681126d4aea07ee1e5dc5ee581 /drivers/target | |
| parent | target/user: Fix use-after-free of tcmu_cmds if they are expired (diff) | |
| download | linux-a91918cd3ea11f91c68e08e1e8ce1b560447a80e.tar.xz linux-a91918cd3ea11f91c68e08e1e8ce1b560447a80e.zip | |
target/iscsi: Fix double free in lio_target_tiqn_addtpg()
This iscsit_tpg_add_portal_group() function is only called from
lio_target_tiqn_addtpg(). Both functions free the "tpg" pointer on
error so it's a double free bug. The memory is allocated in the caller
so it should be freed in the caller and not here.
Fixes: e48354ce078c ("iscsi-target: Add iSCSI fabric support for target v4.1")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: David Disseldorp <ddiss@suse.de>
[ bvanassche: Added "Fix" at start of patch title ]
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Diffstat (limited to 'drivers/target')
| -rw-r--r-- | drivers/target/iscsi/iscsi_target_tpg.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/target/iscsi/iscsi_target_tpg.c b/drivers/target/iscsi/iscsi_target_tpg.c index 552151579a28..2e7e08dbda48 100644 --- a/drivers/target/iscsi/iscsi_target_tpg.c +++ b/drivers/target/iscsi/iscsi_target_tpg.c @@ -260,7 +260,6 @@ err_out: iscsi_release_param_list(tpg->param_list); tpg->param_list = NULL; } - kfree(tpg); return -ENOMEM; } |