summaryrefslogtreecommitdiffstats
path: root/drivers/target
diff options
context:
space:
mode:
authorBart Van Assche <bvanassche@acm.org>2021-04-16 00:08:23 +0200
committerMartin K. Petersen <martin.petersen@oracle.com>2021-04-16 04:44:41 +0200
commit15df85e0d63d870e67fbd39c416f1d9815a107d0 (patch)
tree38df94deee83cf92435ff0df46ce6a7b996db3f8 /drivers/target
parentscsi: sd: Introduce a new local variable in sd_check_events() (diff)
downloadlinux-15df85e0d63d870e67fbd39c416f1d9815a107d0.tar.xz
linux-15df85e0d63d870e67fbd39c416f1d9815a107d0.zip
scsi: target: Compare explicitly with SAM_STAT_GOOD
Instead of leaving it implicit that SAM_STAT_GOOD == 0, compare explicitly with SAM_STAT_GOOD. Link: https://lore.kernel.org/r/20210415220826.29438-18-bvanassche@acm.org Reviewed-by: Mike Christie <michael.christie@oracle.com> Signed-off-by: Bart Van Assche <bvanassche@acm.org> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/target')
-rw-r--r--drivers/target/target_core_pscsi.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/target/target_core_pscsi.c b/drivers/target/target_core_pscsi.c
index 1c9aeab93477..dac44caf77a3 100644
--- a/drivers/target/target_core_pscsi.c
+++ b/drivers/target/target_core_pscsi.c
@@ -1046,7 +1046,7 @@ static void pscsi_req_done(struct request *req, blk_status_t status)
int result = scsi_req(req)->result;
u8 scsi_status = status_byte(result) << 1;
- if (scsi_status) {
+ if (scsi_status != SAM_STAT_GOOD) {
pr_debug("PSCSI Status Byte exception at cmd: %p CDB:"
" 0x%02x Result: 0x%08x\n", cmd, pt->pscsi_cdb[0],
result);