summaryrefslogtreecommitdiffstats
path: root/drivers/target
diff options
context:
space:
mode:
authorYAN SHI <m202071378@hust.edu.cn>2023-04-12 05:35:29 +0200
committerMark Brown <broonie@kernel.org>2023-04-12 13:52:14 +0200
commitc4a413e56d16a2ae84e6d8992f215c4dcc7fac20 (patch)
tree51f6bb29b69ff467733c8e3ddc8364f1d07c239c /drivers/target
parentAdd support for Rockchip RK860X regulators (diff)
downloadlinux-c4a413e56d16a2ae84e6d8992f215c4dcc7fac20.tar.xz
linux-c4a413e56d16a2ae84e6d8992f215c4dcc7fac20.zip
regulator: stm32-pwr: fix of_iomap leak
Smatch reports: drivers/regulator/stm32-pwr.c:166 stm32_pwr_regulator_probe() warn: 'base' from of_iomap() not released on lines: 151,166. In stm32_pwr_regulator_probe(), base is not released when devm_kzalloc() fails to allocate memory or devm_regulator_register() fails to register a new regulator device, which may cause a leak. To fix this issue, replace of_iomap() with devm_platform_ioremap_resource(). devm_platform_ioremap_resource() is a specialized function for platform devices. It allows 'base' to be automatically released whether the probe function succeeds or fails. Besides, use IS_ERR(base) instead of !base as the return value of devm_platform_ioremap_resource() can either be a pointer to the remapped memory or an ERR_PTR() encoded error code if the operation fails. Fixes: dc62f951a6a8 ("regulator: stm32-pwr: Fix return value check in stm32_pwr_regulator_probe()") Signed-off-by: YAN SHI <m202071378@hust.edu.cn> Reported-by: kernel test robot <lkp@intel.com> Link: https://lore.kernel.org/oe-kbuild-all/202304111750.o2643eJN-lkp@intel.com/ Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn> Link: https://lore.kernel.org/r/20230412033529.18890-1-m202071378@hust.edu.cn Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/target')
0 files changed, 0 insertions, 0 deletions