summaryrefslogtreecommitdiffstats
path: root/drivers/tty/amiserial.c
diff options
context:
space:
mode:
authorKrzysztof Kozlowski <k.kozlowski@samsung.com>2016-06-16 08:27:36 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2016-06-25 22:50:53 +0200
commit926b7b5122c96e1f18cd20e85a286c7ec8d18c97 (patch)
tree982d6a4394b0da84a4b7682459f412355fc38cd0 /drivers/tty/amiserial.c
parentserial: samsung: Fix ERR pointer dereference on deferred probe (diff)
downloadlinux-926b7b5122c96e1f18cd20e85a286c7ec8d18c97.tar.xz
linux-926b7b5122c96e1f18cd20e85a286c7ec8d18c97.zip
serial: samsung: Fix possible out of bounds access on non-DT platform
On non-DeviceTree platforms, the index of serial device is a static variable incremented on each probe. It is incremented even if deferred probe happens when getting the clock in s3c24xx_serial_init_port(). This index is used for referencing elements of statically allocated s3c24xx_serial_ports array. In case of re-probe, the index will point outside of this array leading to memory corruption. Increment the index only on successful probe. Reported-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Fixes: b497549a035c ("[ARM] S3C24XX: Split serial driver into core and per-cpu drivers") Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty/amiserial.c')
0 files changed, 0 insertions, 0 deletions