diff options
author | Colin Ian King <colin.i.king@gmail.com> | 2022-07-30 15:09:25 +0200 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-09-01 17:59:36 +0200 |
commit | e4cdd25cafac3f61c74c146db5de7a5c9bd7b6d0 (patch) | |
tree | 2059103b492e6b2ed9df3768d1a9c2f215bb5cf7 /drivers/tty/mxser.c | |
parent | dt-binding: serial: mediatek,uart: update bingding for MT8188 (diff) | |
download | linux-e4cdd25cafac3f61c74c146db5de7a5c9bd7b6d0.tar.xz linux-e4cdd25cafac3f61c74c146db5de7a5c9bd7b6d0.zip |
tty: mxser: remove redundant assignment to hwid
The variable hwid is assigned a value but it is never read. The
assignment is redundant and can be removed.
Cleans up clang scan build warning:
drivers/tty/mxser.c:401:7: warning: Although the value stored to 'hwid'
is used in the enclosing expression, the value is never actually read
from 'hwid' [deadcode.DeadStores]
Acked-by: Jiri Slaby <jirislaby@kernel.org>
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Link: https://lore.kernel.org/r/20220730130925.150018-1-colin.i.king@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to '')
-rw-r--r-- | drivers/tty/mxser.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/tty/mxser.c b/drivers/tty/mxser.c index 3413bd77beed..2436e0b10f9a 100644 --- a/drivers/tty/mxser.c +++ b/drivers/tty/mxser.c @@ -398,7 +398,7 @@ static enum mxser_must_hwid mxser_must_get_hwid(unsigned long io) oldmcr = inb(io + UART_MCR); outb(0, io + UART_MCR); mxser_set_must_xon1_value(io, 0x11); - if ((hwid = inb(io + UART_MCR)) != 0) { + if (inb(io + UART_MCR) != 0) { outb(oldmcr, io + UART_MCR); return MOXA_OTHER_UART; } |