diff options
| author | Jiri Slaby <jslaby@suse.cz> | 2021-06-18 08:14:32 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-06-18 13:10:00 +0200 |
| commit | a1ebc3794e9c737efdaafaeefc054ce473b0751d (patch) | |
| tree | 12860bf58f5597b52707c2c5704c71949064576d /drivers/tty/mxser.c | |
| parent | mxser: remove MOXA_ASPP_LSTATUS ioctl (diff) | |
| download | linux-a1ebc3794e9c737efdaafaeefc054ce473b0751d.tar.xz linux-a1ebc3794e9c737efdaafaeefc054ce473b0751d.zip | |
mxser: remove MOXA_CHKPORTENABLE ioctl
1) MOXA_CHKPORTENABLE is broken at least since commit ecbbfd44a08f (TTY:
move tty buffers to tty_port) in 2012.
2) The ioctl definition was never exposed to userspace, so noone should
actually be reliably using this.
3) It's not even mentioned in any of the mxser utilities.
Provided the above, remove this mxser-special ioctl.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Link: https://lore.kernel.org/r/20210618061516.662-27-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to '')
| -rw-r--r-- | drivers/tty/mxser.c | 10 |
1 files changed, 1 insertions, 9 deletions
diff --git a/drivers/tty/mxser.c b/drivers/tty/mxser.c index 38e12ff17529..ebe657426636 100644 --- a/drivers/tty/mxser.c +++ b/drivers/tty/mxser.c @@ -51,7 +51,6 @@ #define MOXA 0x400 #define MOXA_GETDATACOUNT (MOXA + 23) -#define MOXA_CHKPORTENABLE (MOXA + 60) #define MOXA_HighSpeedOn (MOXA + 61) #define MOXA_GETMSTATUS (MOXA + 65) #define MOXA_SET_OP_MODE (MOXA + 66) @@ -1430,18 +1429,11 @@ static int mxser_ioctl_special(unsigned int cmd, void __user *argp) struct mxser_port *ip; struct tty_port *port; struct tty_struct *tty; - int result, status; + int status; unsigned int i, j; int ret = 0; switch (cmd) { - case MOXA_CHKPORTENABLE: - result = 0; - for (i = 0; i < MXSER_BOARDS; i++) - for (j = 0; j < MXSER_PORTS_PER_BOARD; j++) - if (mxser_boards[i].ports[j].ioaddr) - result |= (1 << i); - return put_user(result, (unsigned long __user *)argp); case MOXA_GETDATACOUNT: /* The receive side is locked by port->slock but it isn't clear that an exact snapshot is worth copying here */ |