diff options
| author | Russell King <rmk+kernel@arm.linux.org.uk> | 2012-10-05 16:13:56 +0200 |
|---|---|---|
| committer | Russell King <rmk+kernel@arm.linux.org.uk> | 2012-11-04 12:26:00 +0100 |
| commit | 511e74f3305e9fce1410f2205084fd67c50f81bc (patch) | |
| tree | ed5d55a825ffc2006cd6824021b8c5c4f388ffa2 /drivers/tty/serial/omap-serial.c | |
| parent | SERIAL: omap: remove setting of EFR SCD bit (diff) | |
| download | linux-511e74f3305e9fce1410f2205084fd67c50f81bc.tar.xz linux-511e74f3305e9fce1410f2205084fd67c50f81bc.zip | |
SERIAL: omap: no need to re-read EFR
There's no need to re-read EFR after we've recently written it; the
register is a configuration register which doesn't change its value
without us writing to it. The last value which was written to this
register was up->efr.
Removing this re-reading avoids the possibility that we end up with
up->efr having unintended bits set, which should only be temporarily
set when accessing the enhanced features.
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Diffstat (limited to 'drivers/tty/serial/omap-serial.c')
| -rw-r--r-- | drivers/tty/serial/omap-serial.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c index 71f968b5504c..6ef4cc49d81e 100644 --- a/drivers/tty/serial/omap-serial.c +++ b/drivers/tty/serial/omap-serial.c @@ -873,8 +873,6 @@ serial_omap_set_termios(struct uart_port *port, struct ktermios *termios, serial_out(up, UART_OMAP_MDR1, up->mdr1); serial_out(up, UART_LCR, UART_LCR_CONF_MODE_B); - - up->efr = serial_in(up, UART_EFR); serial_out(up, UART_EFR, up->efr | UART_EFR_ECB); serial_out(up, UART_LCR, 0); |