summaryrefslogtreecommitdiffstats
path: root/drivers/tty/serial/timbuart.c
diff options
context:
space:
mode:
authorJohan Hovold <johan@kernel.org>2021-04-21 11:55:07 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2021-04-22 12:09:26 +0200
commit177765b350a06493b9437f814384f2a018fd7731 (patch)
tree585a8add9f64c1e3e7a0e9eace026ee4f4bea313 /drivers/tty/serial/timbuart.c
parentserial: sunsu: drop low-latency workaround (diff)
downloadlinux-177765b350a06493b9437f814384f2a018fd7731.tar.xz
linux-177765b350a06493b9437f814384f2a018fd7731.zip
serial: timbuart: drop low-latency workaround
The timbuart driver has always carried a workaround for the infamous low_latency behaviour of tty_flip_buffer_push() which required not holding the port lock when the low_latency flag was set. Since commit a9c3f68f3cd8 ("tty: Fix low_latency BUG"), tty_flip_buffer_push() always schedules a work item to push data to the line discipline and there's no need to keep any low_latency hacks around. Signed-off-by: Johan Hovold <johan@kernel.org> Link: https://lore.kernel.org/r/20210421095509.3024-25-johan@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty/serial/timbuart.c')
-rw-r--r--drivers/tty/serial/timbuart.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/tty/serial/timbuart.c b/drivers/tty/serial/timbuart.c
index 2126e6e6dfd1..08941eabe7b1 100644
--- a/drivers/tty/serial/timbuart.c
+++ b/drivers/tty/serial/timbuart.c
@@ -87,9 +87,7 @@ static void timbuart_rx_chars(struct uart_port *port)
tty_insert_flip_char(tport, ch, TTY_NORMAL);
}
- spin_unlock(&port->lock);
tty_flip_buffer_push(tport);
- spin_lock(&port->lock);
dev_dbg(port->dev, "%s - total read %d bytes\n",
__func__, port->icount.rx);