summaryrefslogtreecommitdiffstats
path: root/drivers/tty/serial
diff options
context:
space:
mode:
authorThomas Abraham <thomas.abraham@linaro.org>2013-01-01 09:21:55 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2013-01-16 06:57:44 +0100
commit41147bfdc5c0d6acb39d2b3b8a4eb6ffb08e4b42 (patch)
tree1f2ab3b6fff41524b1233cdeacd6d9484af639a4 /drivers/tty/serial
parentserial: mxs-auart: Fix typo in sanity check (diff)
downloadlinux-41147bfdc5c0d6acb39d2b3b8a4eb6ffb08e4b42.tar.xz
linux-41147bfdc5c0d6acb39d2b3b8a4eb6ffb08e4b42.zip
serial: samsung: remove the use of statically remapped controller address
The address S3C_VA_UART is a statically ioremapped address. The driver should not be using this. Instead, the driver should setup a mapping during probe. Cc: Kukjin Kim <kgene.kim@samsung.com> Signed-off-by: Thomas Abraham <thomas.abraham@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty/serial')
-rw-r--r--drivers/tty/serial/samsung.c8
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
index 12e5249d053e..96ae08f34770 100644
--- a/drivers/tty/serial/samsung.c
+++ b/drivers/tty/serial/samsung.c
@@ -47,7 +47,6 @@
#include <asm/irq.h>
#include <mach/hardware.h>
-#include <mach/map.h>
#include <plat/regs-serial.h>
#include <plat/clock.h>
@@ -1144,8 +1143,13 @@ static int s3c24xx_serial_init_port(struct s3c24xx_uart_port *ourport,
dbg("resource %p (%lx..%lx)\n", res, res->start, res->end);
+ port->membase = devm_ioremap(port->dev, res->start, resource_size(res));
+ if (!port->membase) {
+ dev_err(port->dev, "failed to remap controller address\n");
+ return -EBUSY;
+ }
+
port->mapbase = res->start;
- port->membase = S3C_VA_UART + (res->start & 0xfffff);
ret = platform_get_irq(platdev, 0);
if (ret < 0)
port->irq = 0;