summaryrefslogtreecommitdiffstats
path: root/drivers/tty
diff options
context:
space:
mode:
authorGeert Uytterhoeven <geert+renesas@glider.be>2018-07-20 14:18:26 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2018-07-21 08:40:51 +0200
commitac8a103e695c500acc83eb5cd816d25d7a6da52f (patch)
tree891df98d62a17a5a61cf60d80bef64b4116d840c /drivers/tty
parentserial: 8250_exar: Describe all members in struct exar8250_board (diff)
downloadlinux-ac8a103e695c500acc83eb5cd816d25d7a6da52f.tar.xz
linux-ac8a103e695c500acc83eb5cd816d25d7a6da52f.zip
serial: sh-sci: Drop superfluous assignment in sci_request_dma()
No later code uses the assigned value, so it can be dropped. Reported-by: Simon Horman <horms@verge.net.au> Fixes: 2c4ee23530ffc022 ("serial: sh-sci: Postpone DMA release when falling back to PIO") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty')
-rw-r--r--drivers/tty/serial/sh-sci.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
index f8e53ac5c17d..6ff6f2bf3b9b 100644
--- a/drivers/tty/serial/sh-sci.c
+++ b/drivers/tty/serial/sh-sci.c
@@ -1574,7 +1574,6 @@ static void sci_request_dma(struct uart_port *port)
if (dma_mapping_error(chan->device->dev, s->tx_dma_addr)) {
dev_warn(port->dev, "Failed mapping Tx DMA descriptor\n");
dma_release_channel(chan);
- chan = NULL;
} else {
dev_dbg(port->dev, "%s: mapped %lu@%p to %pad\n",
__func__, UART_XMIT_SIZE,