diff options
| author | Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2020-07-11 15:53:44 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-07-21 18:21:49 +0200 |
| commit | c6e45ae511b192807376fdd8f9020d5301aeec6d (patch) | |
| tree | 849bb802d8900ecde2eddae632587d0a415c4cc4 /drivers/tty | |
| parent | Revert "serial: amba-pl011: Make sure we initialize the port.lock spinlock" (diff) | |
| download | linux-c6e45ae511b192807376fdd8f9020d5301aeec6d.tar.xz linux-c6e45ae511b192807376fdd8f9020d5301aeec6d.zip | |
Revert "tty: serial: add missing spin_lock_init for SiFive serial console"
This reverts commit 17b4efdf4e4867079012a48ca10d965fe9d68822.
There has been a quick fix against uninitialised lock revealed by
the commit f743061a85f5 ("serial: core: Initialise spin lock before use
in uart_configure_port()"). Since we have now better fix in serial core,
this may be safely reverted.
Fixes: 17b4efdf4e48 ("tty: serial: add missing spin_lock_init for SiFive serial console")
Depends-on: f743061a85f5 ("serial: core: Initialise spin lock before use in uart_configure_port()")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20200711135346.71171-3-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty')
| -rw-r--r-- | drivers/tty/serial/sifive.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/tty/serial/sifive.c b/drivers/tty/serial/sifive.c index 0b5110dad051..13eadcb8aec4 100644 --- a/drivers/tty/serial/sifive.c +++ b/drivers/tty/serial/sifive.c @@ -883,7 +883,6 @@ console_initcall(sifive_console_init); static void __ssp_add_console_port(struct sifive_serial_port *ssp) { - spin_lock_init(&ssp->port.lock); sifive_serial_console_ports[ssp->port.line] = ssp; } |