summaryrefslogtreecommitdiffstats
path: root/drivers/ufs
diff options
context:
space:
mode:
authorCan Guo <quic_cang@quicinc.com>2023-12-02 13:36:08 +0100
committerMartin K. Petersen <martin.petersen@oracle.com>2023-12-14 04:37:20 +0100
commitdc604b4c9d6007c0a03ad90296e849bc38c0d2cc (patch)
tree566f28cf411380ff95a463cc332323590fd43a32 /drivers/ufs
parentscsi: ufs: host: Rename structure ufs_dev_params to ufs_host_params (diff)
downloadlinux-dc604b4c9d6007c0a03ad90296e849bc38c0d2cc.tar.xz
linux-dc604b4c9d6007c0a03ad90296e849bc38c0d2cc.zip
scsi: ufs: ufs-qcom: No need to set hs_rate after ufshcd_init_host_param()
In ufs_qcom_pwr_change_notify(), host_params.hs_rate has been set to PA_HS_MODE_B by ufshcd_init_host_param(), hence remove the duplicated line of work. Meanwhile, removed the macro UFS_QCOM_LIMIT_HS_RATE as it is only used here. Reviewed-by: Nitin Rawat <quic_nitirawa@quicinc.com> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Reviewed-by: Andrew Halaney <ahalaney@redhat.com> Signed-off-by: Can Guo <quic_cang@quicinc.com> Link: https://lore.kernel.org/r/1701520577-31163-3-git-send-email-quic_cang@quicinc.com Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8550-QRD Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/ufs')
-rw-r--r--drivers/ufs/host/ufs-qcom.c1
-rw-r--r--drivers/ufs/host/ufs-qcom.h2
2 files changed, 0 insertions, 3 deletions
diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
index 197c5a5ab136..c21ff2cd7aa6 100644
--- a/drivers/ufs/host/ufs-qcom.c
+++ b/drivers/ufs/host/ufs-qcom.c
@@ -909,7 +909,6 @@ static int ufs_qcom_pwr_change_notify(struct ufs_hba *hba,
switch (status) {
case PRE_CHANGE:
ufshcd_init_host_params(&host_params);
- host_params.hs_rate = UFS_QCOM_LIMIT_HS_RATE;
/* This driver only supports symmetic gear setting i.e., hs_tx_gear == hs_rx_gear */
host_params.hs_tx_gear = host_params.hs_rx_gear = ufs_qcom_get_hs_gear(hba);
diff --git a/drivers/ufs/host/ufs-qcom.h b/drivers/ufs/host/ufs-qcom.h
index 9950a0089475..82cd1436f42d 100644
--- a/drivers/ufs/host/ufs-qcom.h
+++ b/drivers/ufs/host/ufs-qcom.h
@@ -27,8 +27,6 @@
#define SLOW 1
#define FAST 2
-#define UFS_QCOM_LIMIT_HS_RATE PA_HS_MODE_B
-
/* QCOM UFS host controller vendor specific registers */
enum {
REG_UFS_SYS1CLK_1US = 0xC0,