summaryrefslogtreecommitdiffstats
path: root/drivers/usb/atm
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2013-05-19 20:52:20 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2013-05-20 20:35:47 +0200
commit2a0ebf80aa95cc758d4725f74a7016e992606a39 (patch)
tree35fb51826df4e99d781041326e3ce5888afaa76b /drivers/usb/atm
parentUSB: ftdi_sio: Add support for Newport CONEX motor drivers (diff)
downloadlinux-2a0ebf80aa95cc758d4725f74a7016e992606a39.tar.xz
linux-2a0ebf80aa95cc758d4725f74a7016e992606a39.zip
USB: cxacru: potential underflow in cxacru_cm_get_array()
The value of "offd" comes off the instance->rcv_buf[] and we used it as the offset into an array. The problem is that we check the upper bound but not for negative values. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Cc: stable <stable@vger.kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/atm')
-rw-r--r--drivers/usb/atm/cxacru.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/usb/atm/cxacru.c b/drivers/usb/atm/cxacru.c
index b7eb86ad6bf2..8a7eb77233b4 100644
--- a/drivers/usb/atm/cxacru.c
+++ b/drivers/usb/atm/cxacru.c
@@ -686,7 +686,8 @@ static int cxacru_cm_get_array(struct cxacru_data *instance, enum cxacru_cm_requ
{
int ret, len;
__le32 *buf;
- int offb, offd;
+ int offb;
+ unsigned int offd;
const int stride = CMD_PACKET_SIZE / (4 * 2) - 1;
int buflen = ((size - 1) / stride + 1 + size * 2) * 4;