summaryrefslogtreecommitdiffstats
path: root/drivers/usb/dwc2/hcd.c
diff options
context:
space:
mode:
authorGuenter Roeck <linux@roeck-us.net>2019-05-29 22:54:43 +0200
committerFelipe Balbi <felipe.balbi@linux.intel.com>2019-06-18 10:58:29 +0200
commitad408a1596b45868e38d0504f2ec1d5fb06f17d4 (patch)
treeba6621a5a349b71859927468e82711567775447b /drivers/usb/dwc2/hcd.c
parentusb: gadget: net2272: remove redundant assignments to pointer 's' (diff)
downloadlinux-ad408a1596b45868e38d0504f2ec1d5fb06f17d4.tar.xz
linux-ad408a1596b45868e38d0504f2ec1d5fb06f17d4.zip
Revert "usb: dwc2: host: Setting qtd to NULL after freeing it"
This reverts commit b0d659022e5c96ee5c4bd62d22d3da2d66de306b. The reverted commit does nothing but adding two unnecessary lines of code. It sets a local variable to NULL in two functions, but that variable is not used anywhere in the rest of those functions. This is just confusing, so let's remove it. Cc: Vardan Mikayelyan <mvardan@synopsys.com> Cc: John Youn <johnyoun@synopsys.com> Cc: Douglas Anderson <dianders@chromiun.org> Cc: Felipe Balbi <felipe.balbi@linux.intel.com> Acked-by: Minas Harutyunyan <hminas@synopsys.com> Reviewed-by: Douglas Anderson <dianders@chromium.org> Signed-off-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Diffstat (limited to 'drivers/usb/dwc2/hcd.c')
-rw-r--r--drivers/usb/dwc2/hcd.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
index 4c78a390c958..ee144ff8af5b 100644
--- a/drivers/usb/dwc2/hcd.c
+++ b/drivers/usb/dwc2/hcd.c
@@ -4685,7 +4685,6 @@ fail2:
spin_unlock_irqrestore(&hsotg->lock, flags);
urb->hcpriv = NULL;
kfree(qtd);
- qtd = NULL;
fail1:
if (qh_allocated) {
struct dwc2_qtd *qtd2, *qtd2_tmp;