summaryrefslogtreecommitdiffstats
path: root/drivers/usb/dwc3/dwc3-keystone.c
diff options
context:
space:
mode:
authorJulia Lawall <Julia.Lawall@lip6.fr>2014-11-20 18:33:58 +0100
committerFelipe Balbi <balbi@ti.com>2014-11-20 20:35:46 +0100
commit62c606978aa028260f88d0dcb9834bbb7a42b048 (patch)
tree1e752e46561faaa29474b2ffed5559c1d39ee5d0 /drivers/usb/dwc3/dwc3-keystone.c
parentusb: dwc3: trace: don't save pointers (diff)
downloadlinux-62c606978aa028260f88d0dcb9834bbb7a42b048.tar.xz
linux-62c606978aa028260f88d0dcb9834bbb7a42b048.zip
usb: dwc3: keystone: fix error return code
Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Felipe Balbi <balbi@ti.com>
Diffstat (limited to 'drivers/usb/dwc3/dwc3-keystone.c')
-rw-r--r--drivers/usb/dwc3/dwc3-keystone.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/usb/dwc3/dwc3-keystone.c b/drivers/usb/dwc3/dwc3-keystone.c
index dd8d2df6db31..fe3b9335a74e 100644
--- a/drivers/usb/dwc3/dwc3-keystone.c
+++ b/drivers/usb/dwc3/dwc3-keystone.c
@@ -123,6 +123,7 @@ static int kdwc3_probe(struct platform_device *pdev)
irq = platform_get_irq(pdev, 0);
if (irq < 0) {
dev_err(&pdev->dev, "missing irq\n");
+ error = irq;
goto err_irq;
}