diff options
| author | Navid Emamdoost <navid.emamdoost@gmail.com> | 2019-09-30 04:41:45 +0200 |
|---|---|---|
| committer | Felipe Balbi <balbi@kernel.org> | 2019-10-27 07:58:45 +0100 |
| commit | 9bbfceea12a8f145097a27d7c7267af25893c060 (patch) | |
| tree | db49d1c0ee9ea11faa6691fc5daaa551143a1a95 /drivers/usb/dwc3/dwc3-pci.c | |
| parent | usb: gadget: composite: Fix possible double free memory bug (diff) | |
| download | linux-9bbfceea12a8f145097a27d7c7267af25893c060.tar.xz linux-9bbfceea12a8f145097a27d7c7267af25893c060.zip | |
usb: dwc3: pci: prevent memory leak in dwc3_pci_probe
In dwc3_pci_probe a call to platform_device_alloc allocates a device
which is correctly put in case of error except one case: when the call to
platform_device_add_properties fails it directly returns instead of
going to error handling. This commit replaces return with the goto.
Fixes: 1a7b12f69a94 ("usb: dwc3: pci: Supply device properties via driver data")
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Diffstat (limited to 'drivers/usb/dwc3/dwc3-pci.c')
| -rw-r--r-- | drivers/usb/dwc3/dwc3-pci.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c index 5e8e18222f92..023f0357efd7 100644 --- a/drivers/usb/dwc3/dwc3-pci.c +++ b/drivers/usb/dwc3/dwc3-pci.c @@ -258,7 +258,7 @@ static int dwc3_pci_probe(struct pci_dev *pci, const struct pci_device_id *id) ret = platform_device_add_properties(dwc->dwc3, p); if (ret < 0) - return ret; + goto err; ret = dwc3_pci_quirks(dwc); if (ret) |