diff options
| author | Wei Yongjun <yongjun_wei@trendmicro.com.cn> | 2012-09-07 08:54:25 +0200 |
|---|---|---|
| committer | Felipe Balbi <balbi@ti.com> | 2012-09-10 15:19:47 +0200 |
| commit | 162ca3ca613e02e115ec9c5273f94bd22dad0af2 (patch) | |
| tree | ef048bd3f830c5234c2a36b4c4d7fa18fe11034e /drivers/usb/gadget/at91_udc.c | |
| parent | usb: gadget: libcomposite: move MODULE_VERSION to composite.c (diff) | |
| download | linux-162ca3ca613e02e115ec9c5273f94bd22dad0af2.tar.xz linux-162ca3ca613e02e115ec9c5273f94bd22dad0af2.zip | |
usb: gadget: at91_udc: move the dereference below the NULL test
The dereference should be moved below the NULL test.
spatch with a semantic match is used to found this.
(http://coccinelle.lip6.fr/)
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Diffstat (limited to 'drivers/usb/gadget/at91_udc.c')
| -rw-r--r-- | drivers/usb/gadget/at91_udc.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/usb/gadget/at91_udc.c b/drivers/usb/gadget/at91_udc.c index c9e66dfb02e6..d95f6b079345 100644 --- a/drivers/usb/gadget/at91_udc.c +++ b/drivers/usb/gadget/at91_udc.c @@ -469,7 +469,7 @@ static int at91_ep_enable(struct usb_ep *_ep, const struct usb_endpoint_descriptor *desc) { struct at91_ep *ep = container_of(_ep, struct at91_ep, ep); - struct at91_udc *udc = ep->udc; + struct at91_udc *udc; u16 maxpacket; u32 tmp; unsigned long flags; @@ -484,6 +484,7 @@ static int at91_ep_enable(struct usb_ep *_ep, return -EINVAL; } + udc = ep->udc; if (!udc->driver || udc->gadget.speed == USB_SPEED_UNKNOWN) { DBG("bogus device state\n"); return -ESHUTDOWN; |