diff options
author | Andrew Worsley <amworsley@gmail.com> | 2011-11-18 13:13:33 +0100 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-11-18 20:27:16 +0100 |
commit | b1ffb4c851f185e9051ba837c16d9b84ef688d26 (patch) | |
tree | 393552d83086b527a641425ef1634b76b8767585 /drivers/usb/gadget/f_phonet.c | |
parent | USB: option: add PID of Huawei E173s 3G modem (diff) | |
download | linux-b1ffb4c851f185e9051ba837c16d9b84ef688d26.tar.xz linux-b1ffb4c851f185e9051ba837c16d9b84ef688d26.zip |
USB: Fix Corruption issue in USB ftdi driver ftdi_sio.c
Fix for ftdi_set_termios() glitching output
ftdi_set_termios() is constantly setting the baud rate, data bits and parity
unnecessarily on every call, . When called while characters are being
transmitted can cause the FTDI chip to corrupt the serial port bit stream
output by stalling the output half a bit during the output of a character.
Simple fix by skipping this setting if the baud rate/data bits/parity are
unchanged.
Signed-off-by: Andrew Worsley <amworsley@gmail.com>
Cc: stable <stable@vger.kernel.org>
----
I had a brief run with strace on the getty and it was doing ioctl()s on
each call but it didn't look relavant to the problem. I think the issue is
that XON/XOFF flow control was being implmented via hardware - for the ixoff
to allow the user to use XON/XOFF to control output. Unfortunately it would
send 3 Control URBs updating all of the settings after each piece of input
I am trying to work around the issue of gmail messing with the tab/spacing
by submitting via SMTP via gmail which I believe should fix the issue.
The patch is against v3.2-rc2 and compiles - but no additional testing in
this kernel has been done.
Thanks
Andrew
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb/gadget/f_phonet.c')
0 files changed, 0 insertions, 0 deletions