diff options
| author | Alan Stern <stern@rowland.harvard.edu> | 2012-09-19 23:00:55 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-09-21 18:37:53 +0200 |
| commit | 17dcfc9bd3dfb699e00205ec9d431b5a5cb00b34 (patch) | |
| tree | 6ace671b30fd7fd6b1bd3a7aa5b43a37920d3099 /drivers/usb/host/ehci-dbg.c | |
| parent | USB: serial: vizzini: remove outdated comment (diff) | |
| download | linux-17dcfc9bd3dfb699e00205ec9d431b5a5cb00b34.tar.xz linux-17dcfc9bd3dfb699e00205ec9d431b5a5cb00b34.zip | |
USB: EHCI: remove useless test
This patch (as1605) removes a useless test from the EHCI debugfs
code. There's no point checking whether p.qh is non-NULL; we already
know it is and in any case it gets dereferenced aerlier in the
function.
The useless test was identified by smatch.
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/host/ehci-dbg.c')
| -rw-r--r-- | drivers/usb/host/ehci-dbg.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/usb/host/ehci-dbg.c b/drivers/usb/host/ehci-dbg.c index f0c00de035ef..1599806e3d47 100644 --- a/drivers/usb/host/ehci-dbg.c +++ b/drivers/usb/host/ehci-dbg.c @@ -653,10 +653,8 @@ static ssize_t fill_periodic_buffer(struct debug_buffer *buf) seen [seen_count++].qh = p.qh; } else temp = 0; - if (p.qh) { - tag = Q_NEXT_TYPE(ehci, hw->hw_next); - p = p.qh->qh_next; - } + tag = Q_NEXT_TYPE(ehci, hw->hw_next); + p = p.qh->qh_next; break; case Q_TYPE_FSTN: temp = scnprintf (next, size, |