summaryrefslogtreecommitdiffstats
path: root/drivers/usb/host/xhci-mem.c
diff options
context:
space:
mode:
authorOliver Neukum <oneukum@suse.com>2022-02-17 14:35:49 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2022-02-24 11:19:21 +0100
commitf9aeda81c0e8cfd6c5b21401f6206b2c7584f876 (patch)
tree487567acb97092767e0d8bbf7f4f7f4a41de750d /drivers/usb/host/xhci-mem.c
parentusb: host: ehci-q: make qtd_fill() return *unsigned int* (diff)
downloadlinux-f9aeda81c0e8cfd6c5b21401f6206b2c7584f876.tar.xz
linux-f9aeda81c0e8cfd6c5b21401f6206b2c7584f876.zip
xhci: omit mem read just after allocation of trb
This has been allocated just a few lines earlier with a zalloc(). The value is known and "|=" is a waste of memory cycles. Acked-by: Mathias Nyman <mathias.nyman@linux.intel.com> Signed-off-by: Oliver Neukum <oneukum@suse.com> Link: https://lore.kernel.org/r/20220217133549.27961-1-oneukum@suse.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/host/xhci-mem.c')
-rw-r--r--drivers/usb/host/xhci-mem.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c
index f8c2b6c79543..cb70d0b31e08 100644
--- a/drivers/usb/host/xhci-mem.c
+++ b/drivers/usb/host/xhci-mem.c
@@ -57,7 +57,7 @@ static struct xhci_segment *xhci_segment_alloc(struct xhci_hcd *xhci,
/* If the cycle state is 0, set the cycle bit to 1 for all the TRBs */
if (cycle_state == 0) {
for (i = 0; i < TRBS_PER_SEGMENT; i++)
- seg->trbs[i].link.control |= cpu_to_le32(TRB_CYCLE);
+ seg->trbs[i].link.control = cpu_to_le32(TRB_CYCLE);
}
seg->dma = dma;
seg->next = NULL;