summaryrefslogtreecommitdiffstats
path: root/drivers/usb/image/microtek.h
diff options
context:
space:
mode:
authorMing Lei <ming.lei@redhat.com>2019-06-18 03:37:48 +0200
committerMartin K. Petersen <martin.petersen@oracle.com>2019-06-20 21:21:32 +0200
commit1194b5ce57d27c2ad49ed26f8cec98757c7c23ec (patch)
treece74be24a12b0c7139534ba271df8cfcb6767be3 /drivers/usb/image/microtek.h
parentscsi: pmcraid: use sg helper to iterate over scatterlist (diff)
downloadlinux-1194b5ce57d27c2ad49ed26f8cec98757c7c23ec.tar.xz
linux-1194b5ce57d27c2ad49ed26f8cec98757c7c23ec.zip
scsi: usb: image: microtek: use sg helper to iterate over scatterlist
Unlike the legacy I/O path, scsi-mq preallocates a large array to hold the scatterlist for each request. This static allocation can consume substantial amounts of memory on modern controllers which support a large number of concurrently outstanding requests. To facilitate a switch to a smaller static allocation combined with a dynamic allocation for requests that need it, we need to make sure all SCSI drivers handle chained scatterlists correctly. Convert remaining drivers that directly dereference the scatterlist array to using the iterator functions. [mkp: clarified commit message] Cc: Oliver Neukum <oliver@neukum.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Reviewed-by: Bart Van Assche <bvanassche@acm.org> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Ming Lei <ming.lei@redhat.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/usb/image/microtek.h')
-rw-r--r--drivers/usb/image/microtek.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/image/microtek.h b/drivers/usb/image/microtek.h
index 66685e59241a..7bd5f4639c4a 100644
--- a/drivers/usb/image/microtek.h
+++ b/drivers/usb/image/microtek.h
@@ -21,7 +21,7 @@ struct mts_transfer_context
void *data;
unsigned data_length;
int data_pipe;
- int fragment;
+ struct scatterlist *curr_sg;
u8 *scsi_status; /* status returned from ep_response after command completion */
};