summaryrefslogtreecommitdiffstats
path: root/drivers/usb/isp1760/isp1760-udc.c
diff options
context:
space:
mode:
authorValentin Rothberg <Valentin.Rothberg@lip6.fr>2015-03-01 16:54:32 +0100
committerFelipe Balbi <balbi@ti.com>2015-03-09 16:46:15 +0100
commit80b4a0f8feeb6ee7fa4430a2b4ae1155ed923bd2 (patch)
treeefe161d0d579d74b2e098ad2c7549441887a856a /drivers/usb/isp1760/isp1760-udc.c
parentusb: musb: fix Kconfig regression (diff)
downloadlinux-80b4a0f8feeb6ee7fa4430a2b4ae1155ed923bd2.tar.xz
linux-80b4a0f8feeb6ee7fa4430a2b4ae1155ed923bd2.zip
usb: isp1760: set IRQ flags properly
The IRQF_DISABLED is a NOOP and scheduled to be removed. According to commit e58aa3d2d0cc ("genirq: Run irq handlers with interrupts disabled") running IRQ handlers with interrupts enabled can cause stack overflows when the interrupt line of the issuing device is still active. This patch removes using this deprecated flag and additionally removes redundantly setting IRQF_SHARED for isp1760_udc_register(). Signed-off-by: Valentin Rothberg <Valentin.Rothberg@lip6.fr> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Felipe Balbi <balbi@ti.com>
Diffstat (limited to 'drivers/usb/isp1760/isp1760-udc.c')
-rw-r--r--drivers/usb/isp1760/isp1760-udc.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/usb/isp1760/isp1760-udc.c b/drivers/usb/isp1760/isp1760-udc.c
index 19e6a172ff82..47674f9c6df2 100644
--- a/drivers/usb/isp1760/isp1760-udc.c
+++ b/drivers/usb/isp1760/isp1760-udc.c
@@ -1453,8 +1453,8 @@ int isp1760_udc_register(struct isp1760_device *isp, int irq,
sprintf(udc->irqname, "%s (udc)", devname);
- ret = request_irq(irq, isp1760_udc_irq, IRQF_SHARED | IRQF_DISABLED |
- irqflags, udc->irqname, udc);
+ ret = request_irq(irq, isp1760_udc_irq, IRQF_SHARED | irqflags,
+ udc->irqname, udc);
if (ret < 0)
goto error;