diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2023-10-05 16:01:05 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-10-08 07:50:36 +0200 |
| commit | 0f5aa1b01263b8b621bc4f031a1f2983ef8517b7 (patch) | |
| tree | cf1f0f24e55b11eadfc43f34361f0dfc4705cc50 /drivers/usb/misc/usbtest.c | |
| parent | usbip: Use platform_device_register_full() (diff) | |
| download | linux-0f5aa1b01263b8b621bc4f031a1f2983ef8517b7.tar.xz linux-0f5aa1b01263b8b621bc4f031a1f2983ef8517b7.zip | |
usb: usbtest: fix a type promotion bug
The "len" here is sometimes negative error codes from
usb_get_descriptor(), so we don't want to type promote them to unsigned
long.
This bug pre-dates the invention of git.
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/506f7935-2cba-41d9-ab5d-ddb6ad6320bd@moroto.mountain
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/misc/usbtest.c')
| -rw-r--r-- | drivers/usb/misc/usbtest.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/misc/usbtest.c b/drivers/usb/misc/usbtest.c index ac0d75ac2d2f..caf65f8294db 100644 --- a/drivers/usb/misc/usbtest.c +++ b/drivers/usb/misc/usbtest.c @@ -705,7 +705,7 @@ static int is_good_config(struct usbtest_dev *tdev, int len) { struct usb_config_descriptor *config; - if (len < sizeof(*config)) + if (len < (int)sizeof(*config)) return 0; config = (struct usb_config_descriptor *) tdev->buf; |