diff options
| author | Felipe Balbi <balbi@ti.com> | 2013-03-20 07:01:53 +0100 |
|---|---|---|
| committer | Felipe Balbi <balbi@ti.com> | 2013-03-20 07:01:53 +0100 |
| commit | e8d891fb7b8fe4ee7311820594323d46dbc31d45 (patch) | |
| tree | 8419b7cc1b26181fb63ca7fcc39d0614c368b2f0 /drivers/usb/phy/phy-gpio-vbus-usb.c | |
| parent | usb: phy: samsung: fix sparse warning (diff) | |
| download | linux-e8d891fb7b8fe4ee7311820594323d46dbc31d45.tar.xz linux-e8d891fb7b8fe4ee7311820594323d46dbc31d45.zip | |
usb: phy: gpio-vbus: don't ignore regulator APIs return value
Due to recent changes to regulator API, all
users which don't check regulator_{en,dis}able()'s
return value will generate compile warnings.
Add such checks to gpio-vbus.
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Diffstat (limited to 'drivers/usb/phy/phy-gpio-vbus-usb.c')
| -rw-r--r-- | drivers/usb/phy/phy-gpio-vbus-usb.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/drivers/usb/phy/phy-gpio-vbus-usb.c b/drivers/usb/phy/phy-gpio-vbus-usb.c index a7d4ac591982..4c76074e518d 100644 --- a/drivers/usb/phy/phy-gpio-vbus-usb.c +++ b/drivers/usb/phy/phy-gpio-vbus-usb.c @@ -61,6 +61,7 @@ static void set_vbus_draw(struct gpio_vbus_data *gpio_vbus, unsigned mA) { struct regulator *vbus_draw = gpio_vbus->vbus_draw; int enabled; + int ret; if (!vbus_draw) return; @@ -69,12 +70,16 @@ static void set_vbus_draw(struct gpio_vbus_data *gpio_vbus, unsigned mA) if (mA) { regulator_set_current_limit(vbus_draw, 0, 1000 * mA); if (!enabled) { - regulator_enable(vbus_draw); + ret = regulator_enable(vbus_draw); + if (ret < 0) + return; gpio_vbus->vbus_draw_enabled = 1; } } else { if (enabled) { - regulator_disable(vbus_draw); + ret = regulator_disable(vbus_draw); + if (ret < 0) + return; gpio_vbus->vbus_draw_enabled = 0; } } |