diff options
| author | Thierry Reding <treding@nvidia.com> | 2014-07-21 13:37:37 +0200 |
|---|---|---|
| committer | Felipe Balbi <balbi@ti.com> | 2014-09-03 16:16:01 +0200 |
| commit | 9ce9ec95fb9b82e09b55a52f1bb8a362bf8f74d8 (patch) | |
| tree | 81ae94686d8f07f9d16bdfd76bc9229f55531c95 /drivers/usb/phy/phy-tegra-usb.c | |
| parent | doc: dt: mxs-phy: add compatible string for imx6sx-usbphy (diff) | |
| download | linux-9ce9ec95fb9b82e09b55a52f1bb8a362bf8f74d8.tar.xz linux-9ce9ec95fb9b82e09b55a52f1bb8a362bf8f74d8.zip | |
usb: phy: tegra: Avoid use of sizeof(void)
The PHY configuration is stored in an opaque "config" field, but when
allocating the structure, its proper size needs to be known. In the case
of UTMI, the proper structure is tegra_utmip_config of which a local
variable already exists, so we can use that to obtain the size from.
Fixes the following warning from the sparse checker:
drivers/usb/phy/phy-tegra-usb.c:882:17: warning: expression using sizeof(void)
Fixes: 81d5dfe6d8b3 (usb: phy: tegra: Read UTMIP parameters from device tree)
Cc: stable@vger.kernel.org
Signed-off-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Diffstat (limited to 'drivers/usb/phy/phy-tegra-usb.c')
| -rw-r--r-- | drivers/usb/phy/phy-tegra-usb.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c index 13b4fa287da8..886f1807a67b 100644 --- a/drivers/usb/phy/phy-tegra-usb.c +++ b/drivers/usb/phy/phy-tegra-usb.c @@ -878,8 +878,8 @@ static int utmi_phy_probe(struct tegra_usb_phy *tegra_phy, return -ENOMEM; } - tegra_phy->config = devm_kzalloc(&pdev->dev, - sizeof(*tegra_phy->config), GFP_KERNEL); + tegra_phy->config = devm_kzalloc(&pdev->dev, sizeof(*config), + GFP_KERNEL); if (!tegra_phy->config) { dev_err(&pdev->dev, "unable to allocate memory for USB UTMIP config\n"); |