diff options
| author | Aaro Koskinen <aaro.koskinen@iki.fi> | 2013-12-21 19:37:36 +0100 |
|---|---|---|
| committer | Felipe Balbi <balbi@ti.com> | 2013-12-23 17:14:33 +0100 |
| commit | 80f46d5dcb0af46f325c897392baef4911f401b7 (patch) | |
| tree | 2e71c4f5c92e183fa6296405d0c997aa433c5d10 /drivers/usb/phy | |
| parent | usb: phy-twl6030: Add missing braces (diff) | |
| download | linux-80f46d5dcb0af46f325c897392baef4911f401b7.tar.xz linux-80f46d5dcb0af46f325c897392baef4911f401b7.zip | |
usb: phy: tahvo: fix smatch warnings
phy-tahvo introduced the following smatch warnings:
drivers/usb/phy/phy-tahvo.c:203 tahvo_usb_set_host() warn: variable dereferenced before check 'otg' (see line 199)
drivers/usb/phy/phy-tahvo.c:235 tahvo_usb_set_peripheral() warn: variable dereferenced before check 'otg' (see line 231)
Fix by deleting bogus NULL pointer checks. The USB framework will always
call us with a valid OTG pointer.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Diffstat (limited to 'drivers/usb/phy')
| -rw-r--r-- | drivers/usb/phy/phy-tahvo.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/drivers/usb/phy/phy-tahvo.c b/drivers/usb/phy/phy-tahvo.c index 8bb833e22d64..cc61ee44b911 100644 --- a/drivers/usb/phy/phy-tahvo.c +++ b/drivers/usb/phy/phy-tahvo.c @@ -200,9 +200,6 @@ static int tahvo_usb_set_host(struct usb_otg *otg, struct usb_bus *host) dev_dbg(&tu->pt_dev->dev, "%s %p\n", __func__, host); - if (otg == NULL) - return -ENODEV; - mutex_lock(&tu->serialize); if (host == NULL) { @@ -232,9 +229,6 @@ static int tahvo_usb_set_peripheral(struct usb_otg *otg, dev_dbg(&tu->pt_dev->dev, "%s %p\n", __func__, gadget); - if (!otg) - return -ENODEV; - mutex_lock(&tu->serialize); if (!gadget) { |