summaryrefslogtreecommitdiffstats
path: root/drivers/usb/serial/f81232.c
diff options
context:
space:
mode:
authorJohan Hovold <johan@kernel.org>2021-04-07 12:39:03 +0200
committerJohan Hovold <johan@kernel.org>2021-04-08 09:45:52 +0200
commit5486a9dd37f424750b540633d809f1dfef605788 (patch)
tree040122444737be9817220d46c161499e5842ed99 /drivers/usb/serial/f81232.c
parentUSB: serial: ark3116: fix TIOCGSERIAL implementation (diff)
downloadlinux-5486a9dd37f424750b540633d809f1dfef605788.tar.xz
linux-5486a9dd37f424750b540633d809f1dfef605788.zip
USB: serial: f81232: fix TIOCGSERIAL implementation
TIOCSSERIAL is a horrid, underspecified, legacy interface which for most serial devices is only useful for setting the close_delay and closing_wait parameters. The port parameter is used to set the I/O port and does not make any sense to use for USB serial devices. The close_delay and closing_wait parameters returned by TIOCGSERIAL are specified in centiseconds. The driver does not yet support changing these, but let's report back the default values actually used (0.5 and 30 seconds, respectively). Fixes: aac1fc386fa1 ("USB: serial: add Fintek F81232 usb to serial driver") Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Johan Hovold <johan@kernel.org>
Diffstat (limited to 'drivers/usb/serial/f81232.c')
-rw-r--r--drivers/usb/serial/f81232.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81232.c
index 6a8f39147d8e..af0fe2a82eb2 100644
--- a/drivers/usb/serial/f81232.c
+++ b/drivers/usb/serial/f81232.c
@@ -828,8 +828,10 @@ static int f81232_get_serial_info(struct tty_struct *tty,
ss->type = PORT_16550A;
ss->line = port->minor;
- ss->port = port->port_number;
ss->baud_base = priv->baud_base;
+ ss->close_delay = 50;
+ ss->closing_wait = 3000;
+
return 0;
}