summaryrefslogtreecommitdiffstats
path: root/drivers/usb/serial/generic.c
diff options
context:
space:
mode:
authorJohan Hovold <jhovold@gmail.com>2012-02-10 13:20:50 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2012-02-10 19:21:04 +0100
commitf1475a00a11b07e6ac7f97971466c1bfbf491957 (patch)
treec09e56e7d2c3891a36edd3a2037804f8c2a95ca3 /drivers/usb/serial/generic.c
parentUSB: serial: fix console error reporting (diff)
downloadlinux-f1475a00a11b07e6ac7f97971466c1bfbf491957.tar.xz
linux-f1475a00a11b07e6ac7f97971466c1bfbf491957.zip
USB: serial: use dev_err_console in generic write
Use dev_err_console in write path so that an error at least gets reported once. Signed-off-by: Johan Hovold <jhovold@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/serial/generic.c')
-rw-r--r--drivers/usb/serial/generic.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/usb/serial/generic.c b/drivers/usb/serial/generic.c
index e129fcd69fd9..2a2fa2d0489d 100644
--- a/drivers/usb/serial/generic.c
+++ b/drivers/usb/serial/generic.c
@@ -217,10 +217,8 @@ retry:
clear_bit(i, &port->write_urbs_free);
result = usb_submit_urb(urb, GFP_ATOMIC);
if (result) {
- if (!port->port.console) {
- dev_err(&port->dev, "%s - error submitting urb: %d\n",
+ dev_err_console(port, "%s - error submitting urb: %d\n",
__func__, result);
- }
set_bit(i, &port->write_urbs_free);
spin_lock_irqsave(&port->lock, flags);
port->tx_bytes -= count;