diff options
| author | Johan Hovold <johan@kernel.org> | 2017-01-12 14:56:17 +0100 |
|---|---|---|
| committer | Johan Hovold <johan@kernel.org> | 2017-01-16 16:38:56 +0100 |
| commit | 0d130367abf582e7cbf60075c2a7ab53817b1d14 (patch) | |
| tree | f3a87ef9f5e0e24bb08192ecaba15aee164a4999 /drivers/usb/serial/mos7720.c | |
| parent | USB: serial: mct_u232: fix modem-status error handling (diff) | |
| download | linux-0d130367abf582e7cbf60075c2a7ab53817b1d14.tar.xz linux-0d130367abf582e7cbf60075c2a7ab53817b1d14.zip | |
USB: serial: mos7720: fix control-message error handling
Make sure to log an error on short transfers when reading a device
register.
Also clear the provided buffer (which if often an uninitialised
automatic variable) on errors as the driver currently does not bother to
check for errors.
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Diffstat (limited to 'drivers/usb/serial/mos7720.c')
| -rw-r--r-- | drivers/usb/serial/mos7720.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/drivers/usb/serial/mos7720.c b/drivers/usb/serial/mos7720.c index 91bc170b408a..acf431e02699 100644 --- a/drivers/usb/serial/mos7720.c +++ b/drivers/usb/serial/mos7720.c @@ -234,11 +234,16 @@ static int read_mos_reg(struct usb_serial *serial, unsigned int serial_portnum, status = usb_control_msg(usbdev, pipe, request, requesttype, value, index, buf, 1, MOS_WDR_TIMEOUT); - if (status == 1) + if (status == 1) { *data = *buf; - else if (status < 0) + } else { dev_err(&usbdev->dev, "mos7720: usb_control_msg() failed: %d\n", status); + if (status >= 0) + status = -EIO; + *data = 0; + } + kfree(buf); return status; |