diff options
| author | Johan Hovold <johan@kernel.org> | 2019-11-07 14:29:03 +0100 |
|---|---|---|
| committer | Johan Hovold <johan@kernel.org> | 2019-11-12 09:57:26 +0100 |
| commit | f8e8dcaf14d9c2bfb34018cb02e7a40f3d56c8eb (patch) | |
| tree | 3771575e4be1e64fa7fd73dec65cadcc2d4417e4 /drivers/usb/serial/mos7840.c | |
| parent | USB: serial: mos7840: drop port driver data accessors (diff) | |
| download | linux-f8e8dcaf14d9c2bfb34018cb02e7a40f3d56c8eb.tar.xz linux-f8e8dcaf14d9c2bfb34018cb02e7a40f3d56c8eb.zip | |
USB: serial: mos7840: drop read-urb check
Drop read-urb check which is always false from completion the callback.
The driver read-urb pointer is set at every open and is never cleared.
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Diffstat (limited to 'drivers/usb/serial/mos7840.c')
| -rw-r--r-- | drivers/usb/serial/mos7840.c | 11 |
1 files changed, 0 insertions, 11 deletions
diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c index 11706f2d4145..f5c08effa3ab 100644 --- a/drivers/usb/serial/mos7840.c +++ b/drivers/usb/serial/mos7840.c @@ -457,12 +457,6 @@ static void mos7840_bulk_in_callback(struct urb *urb) dev_dbg(&port->dev, "icount.rx is %d:\n", port->icount.rx); } - if (!mos7840_port->read_urb) { - dev_dbg(&port->dev, "%s", "URB KILLED !!!\n"); - mos7840_port->read_urb_busy = false; - return; - } - if (mos7840_port->has_led) mos7840_led_activity(port); @@ -1377,11 +1371,6 @@ static void mos7840_set_termios(struct tty_struct *tty, mos7840_change_port_settings(tty, mos7840_port, old_termios); - if (!mos7840_port->read_urb) { - dev_dbg(&port->dev, "%s", "URB KILLED !!!!!\n"); - return; - } - if (!mos7840_port->read_urb_busy) { mos7840_port->read_urb_busy = true; status = usb_submit_urb(mos7840_port->read_urb, GFP_KERNEL); |