diff options
| author | Alan Cox <alan@lxorguk.ukuu.org.uk> | 2008-04-08 18:16:06 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2008-04-25 06:16:55 +0200 |
| commit | a5b6f60c5a30c494017c7a2d11c4067f90d3d0df (patch) | |
| tree | 2f80d1a6c2655c5c12f40cafbc47516284934d42 /drivers/usb/serial/navman.c | |
| parent | USB: replace remaining __FUNCTION__ occurrences (diff) | |
| download | linux-a5b6f60c5a30c494017c7a2d11c4067f90d3d0df.tar.xz linux-a5b6f60c5a30c494017c7a2d11c4067f90d3d0df.zip | |
usb serial: more fixes and groundwork for tty changes
- If a termios change fails due to lack of memory we should copy the
old settings back over as the device has not changed
- Note various locking problems
- kl5kusb105 had various remaining tty flag handling problems
- Make safe_serial use tty_insert_flip_string not open coded loops
- set termios speed properly in usb_serial
Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb/serial/navman.c')
| -rw-r--r-- | drivers/usb/serial/navman.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/drivers/usb/serial/navman.c b/drivers/usb/serial/navman.c index 7cea325d577c..43c8894353bf 100644 --- a/drivers/usb/serial/navman.c +++ b/drivers/usb/serial/navman.c @@ -6,6 +6,10 @@ * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License * version 2 as published by the Free Software Foundation. + * + * TODO: + * Add termios method that uses copy_hw but also kills all echo + * flags as the navman is rx only so cannot echo. */ #include <linux/kernel.h> @@ -106,12 +110,8 @@ static int navman_write(struct usb_serial_port *port, /* * This device can't write any data, only read from the device - * so we just silently eat all data sent to us and say it was - * successfully sent. - * Evil, I know, but do you have a better idea? */ - - return count; + return -EOPNOTSUPP; } static struct usb_serial_driver navman_device = { |