diff options
| author | Johan Hovold <johan@kernel.org> | 2014-07-29 14:14:55 +0200 |
|---|---|---|
| committer | Johan Hovold <johan@kernel.org> | 2014-08-18 11:05:37 +0200 |
| commit | f0e4cba2534cd88476dff920727c81350130f3c5 (patch) | |
| tree | 5b88acccc4b8826a49d97c109b50ef810cde3197 /drivers/usb/serial/option.c | |
| parent | Linux 3.17-rc1 (diff) | |
| download | linux-f0e4cba2534cd88476dff920727c81350130f3c5.tar.xz linux-f0e4cba2534cd88476dff920727c81350130f3c5.zip | |
USB: option: reduce interrupt-urb logging verbosity
Do not log normal interrupt-urb shutdowns as errors.
The option driver has always been logging any nonzero interrupt-urb
status as an error, including when the urb is killed during normal
operation.
Commit 9096f1fbba91 ("USB: usb_wwan: fix potential NULL-deref at
resume") moved the interrupt urb submission from port probe and release
to open and close, thus potentially increasing the number of these
false-positive error messages dramatically.
Reported-by: Ed Butler <ressy66@ausics.net>
Tested-by: Ed Butler <ressy66@ausics.net>
Cc: <stable@vger.kernel.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Diffstat (limited to 'drivers/usb/serial/option.c')
| -rw-r--r-- | drivers/usb/serial/option.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index a9688940543d..34f142be5b83 100644 --- a/drivers/usb/serial/option.c +++ b/drivers/usb/serial/option.c @@ -1916,6 +1916,8 @@ static void option_instat_callback(struct urb *urb) dev_dbg(dev, "%s: type %x req %x\n", __func__, req_pkt->bRequestType, req_pkt->bRequest); } + } else if (status == -ENOENT || status == -ESHUTDOWN) { + dev_dbg(dev, "%s: urb stopped: %d\n", __func__, status); } else dev_err(dev, "%s: error %d\n", __func__, status); |