diff options
| author | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-09-18 18:07:24 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-09-18 18:07:24 +0200 |
| commit | 93ba0f037bfc7d6c6431c0db767f2244ac583578 (patch) | |
| tree | 7965d02623582dd737ca0a86645aeabeb8e00ed8 /drivers/usb/serial/safe_serial.c | |
| parent | USB: serial: quatech2: fix up unneeded printk() call (diff) | |
| download | linux-93ba0f037bfc7d6c6431c0db767f2244ac583578.tar.xz linux-93ba0f037bfc7d6c6431c0db767f2244ac583578.zip | |
USB: serial: safe-serial: fix up printk() usage
The driver was calling printk() directly at startup, which is just
noise. Switch over to using pr_info() where needed, and get rid of the
totally useless version number that had never ever been incremented.
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/serial/safe_serial.c')
| -rw-r--r-- | drivers/usb/serial/safe_serial.c | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/drivers/usb/serial/safe_serial.c b/drivers/usb/serial/safe_serial.c index e3457e2d2c0d..c949ce6ef0c6 100644 --- a/drivers/usb/serial/safe_serial.c +++ b/drivers/usb/serial/safe_serial.c @@ -62,6 +62,7 @@ * */ +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt #include <linux/kernel.h> #include <linux/errno.h> @@ -84,7 +85,6 @@ static bool safe = 1; static bool padded = CONFIG_USB_SERIAL_SAFE_PADDED; -#define DRIVER_VERSION "v0.1" #define DRIVER_AUTHOR "sl@lineo.com, tbr@lineo.com, Johan Hovold <jhovold@gmail.com>" #define DRIVER_DESC "USB Safe Encapsulated Serial" @@ -311,13 +311,9 @@ static int __init safe_init(void) { int i; - printk(KERN_INFO KBUILD_MODNAME ": " DRIVER_VERSION ":" - DRIVER_DESC "\n"); - /* if we have vendor / product parameters patch them into id list */ if (vendor || product) { - printk(KERN_INFO KBUILD_MODNAME ": vendor: %x product: %x\n", - vendor, product); + pr_info("vendor: %x product: %x\n", vendor, product); for (i = 0; i < ARRAY_SIZE(id_table); i++) { if (!id_table[i].idVendor && !id_table[i].idProduct) { |