summaryrefslogtreecommitdiffstats
path: root/drivers/usb/serial
diff options
context:
space:
mode:
authorRay Lee <ray-lk@madrabbit.org>2008-03-05 00:25:12 +0100
committerGreg Kroah-Hartman <gregkh@suse.de>2008-04-25 06:16:40 +0200
commitb56394bf325820e9f338eaef2941f18b17b98098 (patch)
tree46a38ee7583d5341ec69d257029218e805fb3ccb /drivers/usb/serial
parentUSB: use DIV_ROUND_UP (diff)
downloadlinux-b56394bf325820e9f338eaef2941f18b17b98098.tar.xz
linux-b56394bf325820e9f338eaef2941f18b17b98098.zip
USB: io_ti.c: remove unneeded null tty check
The Coverity checker (and Adrian Bunk) spotted an inconsistent NULL check of port->tty (it's blindly dereferenced later without the check). Alan Cox confirmed the check can go. Signed-off-by: Ray Lee <ray-lk@madrabbit.org> Cc: Adrian Bunk <bunk@kernel.org> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb/serial')
-rw-r--r--drivers/usb/serial/io_ti.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/usb/serial/io_ti.c b/drivers/usb/serial/io_ti.c
index 6afee30a6a5c..316467ecd778 100644
--- a/drivers/usb/serial/io_ti.c
+++ b/drivers/usb/serial/io_ti.c
@@ -1941,8 +1941,7 @@ static int edge_open (struct usb_serial_port *port, struct file * filp)
if (edge_port == NULL)
return -ENODEV;
- if (port->tty)
- port->tty->low_latency = low_latency;
+ port->tty->low_latency = low_latency;
port_number = port->number - port->serial->minor;
switch (port_number) {