summaryrefslogtreecommitdiffstats
path: root/drivers/usb/serial
diff options
context:
space:
mode:
authorJohan Hovold <johan@kernel.org>2020-07-01 18:53:41 +0200
committerJohan Hovold <johan@kernel.org>2020-07-02 10:38:43 +0200
commitc34a917aeff44fb5b2afeef7f5e946e4de405d5a (patch)
treef1acb5e3518ae655cba9718e032e8d77484064e8 /drivers/usb/serial
parentUSB: serial: keyspan_pda: drop unused firmware reset status (diff)
downloadlinux-c34a917aeff44fb5b2afeef7f5e946e4de405d5a.tar.xz
linux-c34a917aeff44fb5b2afeef7f5e946e4de405d5a.zip
USB: serial: kobil_sct: log failure to update line settings
Log failure to update the line settings in set_termios(). This also avoids a W=1 (-Wunused-but-set-variable) warning. Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Johan Hovold <johan@kernel.org>
Diffstat (limited to 'drivers/usb/serial')
-rw-r--r--drivers/usb/serial/kobil_sct.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/usb/serial/kobil_sct.c b/drivers/usb/serial/kobil_sct.c
index e9882ba20933..79ce0219fdde 100644
--- a/drivers/usb/serial/kobil_sct.c
+++ b/drivers/usb/serial/kobil_sct.c
@@ -526,6 +526,10 @@ static void kobil_set_termios(struct tty_struct *tty,
0,
KOBIL_TIMEOUT
);
+ if (result) {
+ dev_err(&port->dev, "failed to update line settings: %d\n",
+ result);
+ }
}
static int kobil_ioctl(struct tty_struct *tty,