summaryrefslogtreecommitdiffstats
path: root/drivers/usb
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2011-10-18 08:25:34 +0200
committerGreg Kroah-Hartman <gregkh@suse.de>2011-10-18 22:51:35 +0200
commit0f8fd43c42f2cc249943be76a4db0d058c16b6dc (patch)
tree247334d2cb84c610b1bc4471447311afd7ddfaa9 /drivers/usb
parentUSB: gadget: midi: fix range check in f_midi_out_open() (diff)
downloadlinux-0f8fd43c42f2cc249943be76a4db0d058c16b6dc.tar.xz
linux-0f8fd43c42f2cc249943be76a4db0d058c16b6dc.zip
USB: gadget: midi: memory leak in f_midi_bind_config()
There is a small memory leak on the error paths. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb')
-rw-r--r--drivers/usb/gadget/f_midi.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/usb/gadget/f_midi.c b/drivers/usb/gadget/f_midi.c
index ef1bc7a174ef..67b222908cf9 100644
--- a/drivers/usb/gadget/f_midi.c
+++ b/drivers/usb/gadget/f_midi.c
@@ -951,7 +951,7 @@ int __init f_midi_bind_config(struct usb_configuration *c,
struct gmidi_in_port *port = kzalloc(sizeof(*port), GFP_KERNEL);
if (!port) {
status = -ENOMEM;
- goto fail;
+ goto setup_fail;
}
port->midi = midi;
@@ -989,6 +989,8 @@ int __init f_midi_bind_config(struct usb_configuration *c,
return 0;
setup_fail:
+ for (--i; i >= 0; i--)
+ kfree(midi->in_port[i]);
kfree(midi);
fail:
return status;