diff options
| author | Jack Pham <jackp@codeaurora.org> | 2020-01-31 04:10:35 +0100 |
|---|---|---|
| committer | Felipe Balbi <balbi@kernel.org> | 2020-02-11 07:45:45 +0100 |
| commit | c724417baf162bd3e035659e22cdf990cfb0d917 (patch) | |
| tree | f35b42b2db5a606330f8ccbb9f7d56c1bbd21e87 /drivers/usb | |
| parent | usb: gadget: u_audio: Fix high-speed max packet size (diff) | |
| download | linux-c724417baf162bd3e035659e22cdf990cfb0d917.tar.xz linux-c724417baf162bd3e035659e22cdf990cfb0d917.zip | |
usb: gadget: composite: Fix bMaxPower for SuperSpeedPlus
SuperSpeedPlus peripherals must report their bMaxPower of the
configuration descriptor in units of 8mA as per the USB 3.2
specification. The current switch statement in encode_bMaxPower()
only checks for USB_SPEED_SUPER but not USB_SPEED_SUPER_PLUS so
the latter falls back to USB 2.0 encoding which uses 2mA units.
Replace the switch with a simple if/else.
Fixes: eae5820b852f ("usb: gadget: composite: Write SuperSpeedPlus config descriptors")
Signed-off-by: Jack Pham <jackp@codeaurora.org>
Signed-off-by: Felipe Balbi <balbi@kernel.org>
Diffstat (limited to 'drivers/usb')
| -rw-r--r-- | drivers/usb/gadget/composite.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c index 3b4f67000315..cd303a3ea680 100644 --- a/drivers/usb/gadget/composite.c +++ b/drivers/usb/gadget/composite.c @@ -437,12 +437,10 @@ static u8 encode_bMaxPower(enum usb_device_speed speed, val = CONFIG_USB_GADGET_VBUS_DRAW; if (!val) return 0; - switch (speed) { - case USB_SPEED_SUPER: - return DIV_ROUND_UP(val, 8); - default: + if (speed < USB_SPEED_SUPER) return DIV_ROUND_UP(val, 2); - } + else + return DIV_ROUND_UP(val, 8); } static int config_buf(struct usb_configuration *config, |