diff options
| author | David Vrabel <david.vrabel@csr.com> | 2008-11-07 19:19:19 +0100 |
|---|---|---|
| committer | David Vrabel <david.vrabel@csr.com> | 2008-11-07 19:19:19 +0100 |
| commit | 58be81ed301d96045bca2b85f3b838910efcfde4 (patch) | |
| tree | d65d13f757652cd2126b43449727c2a1f40ab551 /drivers/uwb/lc-rc.c | |
| parent | uwb: don't unbind the radio controller driver when resetting (diff) | |
| download | linux-58be81ed301d96045bca2b85f3b838910efcfde4.tar.xz linux-58be81ed301d96045bca2b85f3b838910efcfde4.zip | |
uwb: fix races between events and neh timers
Always use del_timer_sync() before freeing nehs. Destroy all nehs after
stopping the radio controller and before cleaning up the reservation
manager. Handle the timer running after an event has removed the neh.
This fixes various oopses that may occur if a radio controller is removed
while a neh timer is still active.
Signed-off-by: David Vrabel <david.vrabel@csr.com>
Diffstat (limited to 'drivers/uwb/lc-rc.c')
| -rw-r--r-- | drivers/uwb/lc-rc.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/uwb/lc-rc.c b/drivers/uwb/lc-rc.c index 38e3d57ec8f7..f00633d334dd 100644 --- a/drivers/uwb/lc-rc.c +++ b/drivers/uwb/lc-rc.c @@ -79,7 +79,6 @@ static void uwb_rc_sys_release(struct device *dev) struct uwb_dev *uwb_dev = container_of(dev, struct uwb_dev, dev); struct uwb_rc *rc = container_of(uwb_dev, struct uwb_rc, uwb_dev); - uwb_rc_neh_destroy(rc); uwb_rc_ie_release(rc); kfree(rc); } @@ -311,7 +310,7 @@ void uwb_rc_rm(struct uwb_rc *rc) rc->ready = 0; uwb_dbg_del_rc(rc); - uwb_rsv_cleanup(rc); + uwb_rsv_remove_all(rc); uwb_rc_ie_rm(rc, UWB_IDENTIFICATION_IE); if (rc->beaconing >= 0) uwb_rc_beacon(rc, -1, 0); @@ -322,6 +321,7 @@ void uwb_rc_rm(struct uwb_rc *rc) rc->stop(rc); uwbd_stop(rc); + uwb_rc_neh_destroy(rc); uwb_dev_lock(&rc->uwb_dev); rc->priv = NULL; @@ -331,6 +331,7 @@ void uwb_rc_rm(struct uwb_rc *rc) uwb_dev_for_each(rc, uwb_dev_offair_helper, NULL); __uwb_rc_sys_rm(rc); mutex_unlock(&rc->uwb_beca.mutex); + uwb_rsv_cleanup(rc); uwb_beca_release(rc); uwb_dev_rm(&rc->uwb_dev); } |