diff options
author | Kiyoshi Ueda <k-ueda@ct.jp.nec.com> | 2011-01-13 21:00:00 +0100 |
---|---|---|
committer | Alasdair G Kergon <agk@redhat.com> | 2011-01-13 21:00:00 +0100 |
commit | 052189a2ec956810feefb6a681416c5e6a207646 (patch) | |
tree | 52a1fbec2878788c6a2f6565999b97331493bc4c /drivers/uwb | |
parent | dm log: use PTR_ERR value instead of ENOMEM (diff) | |
download | linux-052189a2ec956810feefb6a681416c5e6a207646.tar.xz linux-052189a2ec956810feefb6a681416c5e6a207646.zip |
dm: remove superfluous irq disablement in dm_request_fn
This patch changes spin_lock_irq() to spin_lock() in dm_request_fn().
This patch is just a clean-up and no functional change.
The spin_lock_irq() was leftover from the early request-based dm code,
where map_request() used to enable interrupts.
Since current map_request() never enables interrupts, we can change it
to spin_lock() to match the prior spin_unlock().
Auditing through the dm and block-layer code called from
map_request(), I confirmed all functions save/restore interrupt
status, so no function returning with interrupts enabled.
Also I haven't observed any problem on my test environment which
uses scsi and lpfc driver after heavy I/O testing with occasional
path down/up.
Added BUG_ON() to detect breakage in future.
Signed-off-by: Kiyoshi Ueda <k-ueda@ct.jp.nec.com>
Signed-off-by: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>
Diffstat (limited to 'drivers/uwb')
0 files changed, 0 insertions, 0 deletions