diff options
| author | Michael S. Tsirkin <mst@redhat.com> | 2011-03-13 22:00:52 +0100 |
|---|---|---|
| committer | Michael S. Tsirkin <mst@redhat.com> | 2011-03-13 22:08:19 +0100 |
| commit | de4d768a428d9de943dd6dc82bcd61742955cb6e (patch) | |
| tree | 68b0d3c4b3ce4158664e65c2deb9bf59d3a5e028 /drivers/vhost | |
| parent | vhost: lock receive queue, not the socket (diff) | |
| download | linux-de4d768a428d9de943dd6dc82bcd61742955cb6e.tar.xz linux-de4d768a428d9de943dd6dc82bcd61742955cb6e.zip | |
vhost-net: remove unlocked use of receive_queue
Use of skb_queue_empty(&sock->sk->sk_receive_queue)
without taking the sk_receive_queue.lock is unsafe
or useless. Take it out.
Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'drivers/vhost')
| -rw-r--r-- | drivers/vhost/net.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c index 57203014c457..2f7c76a85e53 100644 --- a/drivers/vhost/net.c +++ b/drivers/vhost/net.c @@ -311,7 +311,7 @@ static void handle_rx(struct vhost_net *net) /* TODO: check that we are running from vhost_worker? */ struct socket *sock = rcu_dereference_check(vq->private_data, 1); - if (!sock || skb_queue_empty(&sock->sk->sk_receive_queue)) + if (!sock) return; mutex_lock(&vq->mutex); |